fix: control-panel search #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. WalkthroughAdds EVaultService methods for logs/metrics fetching, refactors selection in the main page from index- to id/name-based, enhances the logs API with namespace/pod existence checks and refined errors, and introduces a runtime polyfill on the monitoring page to ensure EVaultService methods exist. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor U as User
participant M as Monitoring Page
participant S as EVaultService<br/>(native or polyfill)
participant API as /api/evaults/{ns}/{pod}/logs
participant K as kubectl
U->>M: Open monitoring view
M->>S: getEVaultLogs(ns, pod)
alt Native implementation
S->>API: GET /logs
else Polyfill
S->>API: GET /logs
end
API->>K: kubectl get namespace {ns}
alt Namespace missing
API-->>S: 404 Namespace not found
S-->>M: Throw error
M-->>U: Show error
else Namespace exists
API->>K: kubectl get pod {pod} -n {ns}
alt Pod missing
API-->>S: 404 Pod not found
S-->>M: Throw error
M-->>U: Show error
else Pod exists
API->>K: kubectl logs -n {ns} {pod} -c evault --tail={tail}
K-->>API: stdout (logs)
API-->>S: 200 { logs: [...] }
S-->>M: logs[]
M-->>U: Render logs
end
end
sequenceDiagram
autonumber
actor U as User
participant CP as Control Panel Page
participant DS as Data Store<br/>(sessionStorage)
U->>CP: Select eVaults/platforms
CP->>CP: Map selection by evaultId/platform.name via filtered lists
CP->>DS: Persist selected objects keyed by id/name
U->>CP: Click "Go to Monitoring"
CP->>CP: Reconstruct selections from ids/names
CP-->>U: Navigate with resolved targets
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (4)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Issue Number
Type of change
How the change has been tested
Change checklist
Summary by CodeRabbit
New Features
Improvements
Bug Fixes